chore(reference): use API Extractor for TypeScript rollup #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glowcloud
added
enhancement
glowcloud
commented
Nov 21, 2024
| @@ -31,6 +32,13 @@ export type { BundleStrategyOptions } from './bundle/strategies/BundleStrategy.t | |||
|
|
|||
| export { default as options } from './options/index.ts'; | |||
| export { merge as mergeOptions } from './options/util.ts'; | |||
| export type { | |||
| ReferenceOptions as ApiDOMReferenceOptions, | |||
There was a problem hiding this comment.
Went with the ApiDOM prefix for these exports as ReferenceOptions has to be renamed due to another export:
export type { ReferenceOptions } from './Reference.ts';Not sure what else we could go for, except for perhaps dropping the Reference part from all of them
Suggested change
| ReferenceOptions as ApiDOMReferenceOptions, | |
| ReferenceOptions as Options, | |
| ReferenceBundleOptions as BundleOptions, | |
| ... |
char0n
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4382